fides icon indicating copy to clipboard operation
fides copied to clipboard

Removing some instances of async_session.begin()

Open galvana opened this issue 4 months ago • 2 comments

Closes []

Description Of Changes

Write some things here about the changes and any potential caveats

Code Changes

  • list your code changes here

Steps to Confirm

  1. list any manual steps for reviewers to confirm the changes

Pre-Merge Checklist

  • [ ] Issue requirements met
  • [ ] All CI pipelines succeeded
  • [ ] CHANGELOG.md updated
    • [ ] Add a https://github.com/ethyca/fides/labels/db-migration label to the entry if your change includes a DB migration
    • [ ] Add a https://github.com/ethyca/fides/labels/high-risk label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • [ ] Updates unreleased work already in Changelog, no new entry necessary
  • Followup issues:
    • [ ] Followup issues created
    • [ ] No followup issues
  • Database migrations:
    • [ ] Ensure that your downrev is up to date with the latest revision on main
    • [ ] Ensure that your downgrade() migration is correct and works
      • [ ] If a downgrade migration is not possible for this change, please call this out in the PR description!
    • [ ] No migrations
  • Documentation:
    • [ ] Documentation complete, PR opened in fidesdocs
    • [ ] Documentation issue created in fidesdocs
    • [ ] If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • [ ] No documentation updates required

galvana avatar Aug 28 '25 16:08 galvana

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
fides-plus-nightly Ignored Ignored Preview Aug 29, 2025 1:46am
fides-privacy-center Ignored Ignored Aug 29, 2025 1:46am

vercel[bot] avatar Aug 28 '25 16:08 vercel[bot]

Codecov Report

:x: Patch coverage is 4.00000% with 72 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 82.27%. Comparing base (b400cd4) to head (9f848f0). :warning: Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
src/fides/api/db/crud.py 4.68% 61 Missing :warning:
src/fides/api/db/system.py 0.00% 11 Missing :warning:

:x: Your project check has failed because the head coverage (82.27%) is below the target coverage (85.00%). You can increase the head coverage or adjust the target coverage.

:exclamation: There is a different number of reports uploaded between BASE (b400cd4) and HEAD (9f848f0). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (b400cd4) HEAD (9f848f0)
16 14
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6513      +/-   ##
==========================================
- Coverage   87.68%   82.27%   -5.41%     
==========================================
  Files         481      481              
  Lines       30792    30805      +13     
  Branches     3462     3466       +4     
==========================================
- Hits        27000    25346    -1654     
- Misses       3051     4765    +1714     
+ Partials      741      694      -47     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Aug 28 '25 17:08 codecov[bot]