fides icon indicating copy to clipboard operation
fides copied to clipboard

ENG-487 use persisted identities

Open erosselli opened this issue 4 months ago • 2 comments

Closes []

Description Of Changes

Write some things here about the changes and any potential caveats

Code Changes

  • list your code changes here

Steps to Confirm

  1. list any manual steps for reviewers to confirm the changes

Pre-Merge Checklist

  • [ ] Issue requirements met
  • [ ] All CI pipelines succeeded
  • [ ] CHANGELOG.md updated
    • [ ] Add a https://github.com/ethyca/fides/labels/db-migration label to the entry if your change includes a DB migration
    • [ ] Add a https://github.com/ethyca/fides/labels/high-risk label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • [ ] Updates unreleased work already in Changelog, no new entry necessary
  • Followup issues:
    • [ ] Followup issues created
    • [ ] No followup issues
  • Database migrations:
    • [ ] Ensure that your downrev is up to date with the latest revision on main
    • [ ] Ensure that your downgrade() migration is correct and works
      • [ ] If a downgrade migration is not possible for this change, please call this out in the PR description!
    • [ ] No migrations
  • Documentation:
    • [ ] Documentation complete, PR opened in fidesdocs
    • [ ] Documentation issue created in fidesdocs
    • [ ] If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • [ ] No documentation updates required

erosselli avatar Aug 11 '25 12:08 erosselli

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Aug 11, 2025 1:27pm
fides-privacy-center ⬜️ Ignored (Inspect) Aug 11, 2025 1:27pm

vercel[bot] avatar Aug 11 '25 12:08 vercel[bot]

Codecov Report

:x: Patch coverage is 55.88235% with 15 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 61.05%. Comparing base (c0b9909) to head (86551e6).

Files with missing lines Patch % Lines
...ides/api/models/privacy_request/privacy_request.py 72.72% 4 Missing and 2 partials :warning:
src/fides/api/util/saas_util.py 0.00% 4 Missing :warning:
src/fides/service/messaging/messaging_service.py 0.00% 2 Missing :warning:
.../api/service/connectors/consent_email_connector.py 0.00% 1 Missing :warning:
.../api/service/connectors/erasure_email_connector.py 0.00% 1 Missing :warning:
...vice/connectors/query_configs/saas_query_config.py 0.00% 1 Missing :warning:

:x: Your patch check has failed because the patch coverage (55.88%) is below the target coverage (100.00%). You can increase the patch coverage or adjust the target coverage. :x: Your project check has failed because the head coverage (61.05%) is below the target coverage (85.00%). You can increase the head coverage or adjust the target coverage.

:exclamation: There is a different number of reports uploaded between BASE (c0b9909) and HEAD (86551e6). Click for more details.

HEAD has 4 uploads less than BASE
Flag BASE (c0b9909) HEAD (86551e6)
14 10
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #6442       +/-   ##
===========================================
- Coverage   85.47%   61.05%   -24.42%     
===========================================
  Files         455      455               
  Lines       29234    29258       +24     
  Branches     3241     3246        +5     
===========================================
- Hits        24988    17864     -7124     
- Misses       3526    10776     +7250     
+ Partials      720      618      -102     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Aug 11 '25 13:08 codecov[bot]