Updates Language-selector to be react-driven, ensuring it closes after selection
Closes https://ethyca.atlassian.net/browse/ENG-721
Description Of Changes
Updates Language-selector to automatically close after language selection
https://www.loom.com/share/c610e9c428494874b543a9751cb8c370
Code Changes
- Update open/close state to be react-driven
- Update CSS accordingly
Steps to Confirm
- Navigate to an experience with multiple languages
- For both the banner and modal components do the following:
- Hover over the language selector, confirm the language modal opens as before
- Make a selection, confirm it closes automatically
- Hover over it again, then stop hovering over it. Confirm it closes as before
Pre-Merge Checklist
- [ ] Issue requirements met
- [ ] All CI pipelines succeeded
- [ ]
CHANGELOG.mdupdated- [ ] Add a https://github.com/ethyca/fides/labels/db-migration label to the entry if your change includes a DB migration
- [ ] Add a https://github.com/ethyca/fides/labels/high-risk label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
- [ ] Updates unreleased work already in Changelog, no new entry necessary
- Followup issues:
- [ ] Followup issues created
- [ ] No followup issues
- Database migrations:
- [ ] Ensure that your downrev is up to date with the latest revision on
main - [ ] Ensure that your
downgrade()migration is correct and works- [ ] If a downgrade migration is not possible for this change, please call this out in the PR description!
- [ ] No migrations
- [ ] Ensure that your downrev is up to date with the latest revision on
- Documentation:
- [ ] Documentation complete, PR opened in fidesdocs
- [ ] Documentation issue created in fidesdocs
- [ ] If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
- [ ] No documentation updates required
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| fides-plus-nightly | 🛑 Canceled (Inspect) | Jul 2, 2025 6:07pm |
1 Skipped Deployment
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| fides-privacy-center | ⬜️ Ignored (Inspect) | Jul 2, 2025 6:07pm |
@eastandwestwind - I have tested this on mobile and verified it addresses the issue there - it shows and hides as intended. I'm less familiar with the web, but I did notice that it opens immediately on mouse over, and I'm not sure if that's the same as the behavior was before, but it works fine on web as well. So looks good in testing
Approving the PR (the merge conflict should be easy to resolve) - I did have one question after reviewing
One more note here: This isn't working at all on a mobile sized screen for the TCF banner. Some of the suggestions above may help mitigate that but be sure to include that in your dev testing.
One more note here: This isn't working at all on a mobile sized screen for the TCF banner. Some of the suggestions above may help mitigate that but be sure to include that in your dev testing.
Not sure if this is what you are seeing Jason, but I'm getting some inconsistent behavior here in my local environment. I had originally tested this and found it working, but it is sometimes not showing up for me in mobile Safari and in the SDK webview
You'll notice in the screenshot where it isn't working the privacy notice rows aren't loading either - and looking at the DOM when its broken, I found this wasn't an issue with the element being hidden, but missing altogether, so it might be an issue with the translations from the backend not loading as the dropdown won't load if there are no translations from the BE
Not sure if this is what you are seeing Jason
@thabofletcher these screenshots appear to be from the TCF Modal, I'm seeing issues on TCF Banner specifically, where the button doesn't open the language selector at all.
Not sure if this is what you are seeing Jason
@thabofletcher these screenshots appear to be from the TCF Modal, I'm seeing issues on TCF Banner specifically, where the button doesn't open the language selector at all.
That's probably ok from a mobile SDK perspective since we use fides_disable_banner=true to skip the banner in banner_and_modal. But maybe something to discover and address just from an overall correct behavior standpoint?
fides
Run #13055
Run Properties:
Passed #13055 •
1e58497d61: Updates Language-selector to be react-driven, ensuring it closes after selection...
| Project |
fides
|
| Branch Review |
main
|
| Run status |
|
| Run duration | 00m 54s |
| Commit |
|
| Committer | Catherine Smith |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
|
0
|
|
|
0
|
|
|
0
|
|
|
0
|
|
|
5
|
| View all changes introduced in this branch ↗︎ | |