fides icon indicating copy to clipboard operation
fides copied to clipboard

async readonly

Open tvandort opened this issue 10 months ago • 2 comments

Closes []

Description Of Changes

Write some things here about the changes and any potential caveats

Code Changes

  • list your code changes here

Steps to Confirm

  1. list any manual steps for reviewers to confirm the changes

Pre-Merge Checklist

  • [ ] Issue requirements met
  • [ ] All CI pipelines succeeded
  • [ ] CHANGELOG.md updated
    • [ ] Add a https://github.com/ethyca/fides/labels/db-migration label to the entry if your change includes a DB migration
    • [ ] Add a https://github.com/ethyca/fides/labels/high-risk label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • [ ] Updates unreleased work already in Changelog, no new entry necessary
  • Followup issues:
    • [ ] Followup issues created
    • [ ] No followup issues
  • Database migrations:
    • [ ] Ensure that your downrev is up to date with the latest revision on main
    • [ ] Ensure that your downgrade() migration is correct and works
      • [ ] If a downgrade migration is not possible for this change, please call this out in the PR description!
    • [ ] No migrations
  • Documentation:
    • [ ] Documentation complete, PR opened in fidesdocs
    • [ ] Documentation issue created in fidesdocs
    • [ ] If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • [ ] No documentation updates required

tvandort avatar Jun 01 '25 23:06 tvandort

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Jun 2, 2025 2:16am
fides-privacy-center ⬜️ Ignored (Inspect) Jun 2, 2025 2:16am

vercel[bot] avatar Jun 01 '25 23:06 vercel[bot]

Codecov Report

:x: Patch coverage is 36.36364% with 14 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 86.53%. Comparing base (b38cb86) to head (2d4895f).

Files with missing lines Patch % Lines
src/fides/config/database_settings.py 33.33% 8 Missing and 2 partials :warning:
src/fides/api/db/ctl_session.py 42.85% 4 Missing :warning:

:x: Your patch status has failed because the patch coverage (36.36%) is below the target coverage (100.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@                Coverage Diff                 @@
##           release-2.61.1    #6187      +/-   ##
==================================================
- Coverage           86.61%   86.53%   -0.09%     
==================================================
  Files                 423      423              
  Lines               26353    26137     -216     
  Branches             2864     2842      -22     
==================================================
- Hits                22825    22617     -208     
+ Misses               2912     2909       -3     
+ Partials              616      611       -5     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Jun 02 '25 00:06 codecov[bot]