fides icon indicating copy to clipboard operation
fides copied to clipboard

ENG-651: use `npm ci`

Open tvandort opened this issue 10 months ago • 2 comments

Closes ENG-651

Description Of Changes

Changes npm i to npm ci in our build pipelines.

https://docs.npmjs.com/cli/v11/commands/npm-ci#description

I want to change this so that I can use git status to detect whether autogenerated files have been accidentally manually edited by developers when they raise PRs. Right now npm i can cause dependencies to change which means the check I just described always fails even if there are no accidental changes.

That being said this PR should also help detect prior issues we've had with differing versions between packages.

Code Changes

  • list your code changes here

Steps to Confirm

  1. Pipelines should pass.
  2. Developer commands should still work.

Pre-Merge Checklist

  • [ ] Issue requirements met
  • [ ] All CI pipelines succeeded
  • [ ] CHANGELOG.md updated
    • [ ] Add a https://github.com/ethyca/fides/labels/db-migration label to the entry if your change includes a DB migration
    • [ ] Add a https://github.com/ethyca/fides/labels/high-risk label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • [ ] Updates unreleased work already in Changelog, no new entry necessary
  • Followup issues:
    • [ ] Followup issues created
    • [ ] No followup issues
  • Database migrations:
    • [ ] Ensure that your downrev is up to date with the latest revision on main
    • [ ] Ensure that your downgrade() migration is correct and works
      • [ ] If a downgrade migration is not possible for this change, please call this out in the PR description!
    • [ ] No migrations
  • Documentation:
    • [ ] Documentation complete, PR opened in fidesdocs
    • [ ] Documentation issue created in fidesdocs
    • [ ] If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • [ ] No documentation updates required

tvandort avatar May 27 '25 21:05 tvandort

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Jul 18, 2025 4:08pm
fides-privacy-center ⬜️ Ignored (Inspect) Jul 18, 2025 4:08pm

vercel[bot] avatar May 27 '25 21:05 vercel[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 84.73%. Comparing base (b4bee8f) to head (530d5b0). Report is 1 commits behind head on main.

:x: Your project status has failed because the head coverage (84.73%) is below the target coverage (85.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6174      +/-   ##
==========================================
- Coverage   85.58%   84.73%   -0.85%     
==========================================
  Files         448      448              
  Lines       28607    28607              
  Branches     3178     3178              
==========================================
- Hits        24482    24239     -243     
- Misses       3394     3630     +236     
- Partials      731      738       +7     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar May 27 '25 21:05 codecov[bot]

fides    Run #13136

Run Properties:  status check passed Passed #13136  •  git commit b9fde56822: ENG-651: use `npm ci` (#6174)
Project fides
Branch Review main
Run status status check passed Passed #13136
Run duration 00m 53s
Commit git commit b9fde56822: ENG-651: use `npm ci` (#6174)
Committer Tom Van Dort
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 5
View all changes introduced in this branch ↗︎

cypress[bot] avatar Jul 18 '25 16:07 cypress[bot]