fides icon indicating copy to clipboard operation
fides copied to clipboard

Remove response limit from fides.js

Open andres-torres-marroquin opened this issue 9 months ago • 2 comments

Closes #PROD-2031

Description Of Changes

By default Next.JS throws "API Routes Response Size Limited to 4MB" when the response is larger than 4MB, disabling this will not throw data in the console. But this can allow us to have very big responses without noticing anymore. From the Next.JS docs: API Routes in Next.js are designed to deliver quick responses and are not built to support the transmission of large amounts of data.

Code Changes

  • [ ] Added a config variable to fides-js.ts to change the api.responseLimit to false

Steps to Confirm

  • [ ] Change the script variable on fides-js.ts file to include a lot of comments, just 4MB of it, and you'll get a message on the dev web server shell. After this change gets into main, the message will be gone.

Pre-Merge Checklist

  • [ ] All CI Pipelines Succeeded
  • [ ] Issue Requirements are Met
  • [ ] Update CHANGELOG.md

andres-torres-marroquin avatar May 09 '24 18:05 andres-torres-marroquin

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview May 13, 2024 3:18pm

vercel[bot] avatar May 09 '24 18:05 vercel[bot]

Passing run #7690 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge 6067f96c533ee6f4c8b6a62be9fbef941cd2e8d6 into 29bad50ef6c0a99b5f32f4b4c53b...
Project: fides Commit: 7da902a46e ℹ️
Status: Passed Duration: 00:33 💡
Started: May 10, 2024 9:52 PM Ended: May 10, 2024 9:53 PM

Review all test suite changes for PR #4878 ↗︎

cypress[bot] avatar May 09 '24 18:05 cypress[bot]