Fix quickstart instructions for Apple Silicon Macs
Description Of Changes
- Updates the
brew installcommand for openssl as the default install doesn't include openssl 1.1 - Updates the shell config (e.g. .zshrc) flags for Apple Silicon Macs to include the latest hardcoded freetds version. (There must be a better way of doing this but it'll work until the next freetds update).
Code Changes
- See commit
Steps to Confirm
- [ ] Open a Markdown preview of README.md on this branch
Pre-Merge Checklist
- [ ] All CI Pipelines Succeeded
- Documentation:
- [ ] documentation complete, PR opened in fidesdocs
- [ ] documentation issue created in fidesdocs
- [ ] Issue Requirements are Met
- [ ] Relevant Follow-Up Issues Created
- [ ] Update
CHANGELOG.md - [ ] For API changes, the Postman collection has been updated
@SteveDMurphy, I encountered this when trying to quickstart a freshly wiped Mac. It doesn't make a huge difference because fides on Apple Silicon is broken until the cython/pymssql issue is fixed, but can you think of a better way to fix these flags that doesn't hardcode a version in the paths?
@SteveDMurphy, I encountered this when trying to quickstart a freshly wiped Mac. It doesn't make a huge difference because fides on Apple Silicon is broken until the cython/pymssql issue is fixed, but can you think of a better way to fix these flags that doesn't hardcode a version in the paths?
Hey @daveqnet ! We have run into this a couple of times before, and can see some of our PRs/Issues that have referenced it close to this comment -> https://github.com/mkleehammer/pyodbc/issues/846#issuecomment-986649632
I think what we may want to do here is highlight which version to check for and where to update it versus continually updating to match latest. Will see if I can find something that exists already
How about if we use /opt/homebrew/opt/ paths instead of /opt/homebrew/Cellar/ paths? They're symlinks but they're stable across homebrew version updates and I think it should work.
dave-test@dq-test-mbp ~ % ls -al /opt/homebrew/opt | grep 'ssl\|tds'
lrwxr-xr-x 1 dave-test admin 26 26 Jul 10:10 freetds -> ../Cellar/freetds/1.3.18_1
lrwxr-xr-x 1 dave-test admin 27 26 Jul 10:10 openssl -> ../Cellar/openssl@3/3.1.1_1
lrwxr-xr-x 1 dave-test admin 28 26 Jul 10:13 [email protected] -> ../Cellar/[email protected]/1.1.1u
lrwxr-xr-x 1 dave-test admin 27 26 Jul 10:10 openssl@3 -> ../Cellar/openssl@3/3.1.1_1
lrwxr-xr-x 1 dave-test admin 27 26 Jul 10:10 [email protected] -> ../Cellar/openssl@3/3.1.1_1
Our exports would then be
export LDFLAGS="-L/opt/homebrew/opt/freetds/lib -L/opt/homebrew/opt/[email protected]/lib"
export CFLAGS="-I/opt/homebrew/opt/freetds/include"
but I'm not sure how to test that these flags work. What do you reckon, @SteveDMurphy?
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| fides-plus-nightly | ⬜️ Ignored (Inspect) | Visit Preview | Jan 5, 2024 3:46pm |