fides icon indicating copy to clipboard operation
fides copied to clipboard

ui/config-wizard: Show & review scanner result systems

Open ssangervasi opened this issue 3 years ago • 0 comments

Closes #904

Code Changes

  • Show & review scanner result systems
  • Reset wizard state instead of relying on routing
  • Improved checking of system create vs editing
    • DescribeSystemStep was already querying the existing systems. This info can be used to check if the system that was passed in (if any) already exists (by fides key). This also disable the fides key field so that the user can't accidentally switch to creating a new system by modifying that field.
  • Describe step accepts system object
  • ui/system: Reset active system when navigating from the "new" page

Steps to Confirm

  • [ ] Reviewing AWS systems
    1. Go through the wizard flow through the AWS scanner (fidesctl-integration-test credentials)
    2. Select multiple systems from the scan results table
    3. Fill out the system review forms
    4. The success page should show which have been reviewed and the ones remaining
    5. Hitting "Continue" should move onto more systems until there are none left.
  • [ ] Manually adding systems
    • After going through manual steps, the success page should show the custom system
    • The "Add manual system" button should work.

Pre-Merge Checklist

  • [ ] All CI Pipelines Succeeded
  • Documentation Updated:
    • [ ] documentation complete, or draft/outline provided (tag docs-team to complete/review on this branch)
    • [ ] documentation issue created (tag docs-team to complete issue separately)
  • [x] Issue Requirements are Met
  • [x] Relevant Follow-Up Issues Created
    • The end state issues are separate: https://github.com/orgs/ethyca/projects/17/views/3?filterQuery=is%3Aissue+is%3Aopen+wizard+end+state
  • [x] Update CHANGELOG.md

Description Of Changes

Showing the review status complet-not-complet

The whole review flow

https://user-images.githubusercontent.com/2236777/195933867-f2d2886b-1f8c-432a-b51e-75e291b4cdf3.mp4

Manual flow

https://user-images.githubusercontent.com/2236777/195933951-b32d2191-1c2e-4aee-a250-f783ae3fdc44.mp4

ssangervasi avatar Oct 14 '22 20:10 ssangervasi