fides icon indicating copy to clipboard operation
fides copied to clipboard

Fix mypy errors

Open sanders41 opened this issue 3 years ago • 2 comments

Closes #1148

Code Changes

  • [x] Removed __init__.py from the src dir
  • [x] Removed the global ignore_missing_imports = true and moved needed ignores to the override section
  • [x] Fixed mypy errors

Steps to Confirm

  • [ ] Run mypy
  • [ ] Run test suite

Pre-Merge Checklist

  • [x] All CI Pipelines Succeeded
  • Documentation Updated:
    • [ ] documentation complete, or draft/outline provided (tag docs-team to complete/review on this branch)
    • [ ] documentation issue created (tag docs-team to complete issue separately)
  • [ ] Issue Requirements are Met
  • [ ] Relevant Follow-Up Issues Created
  • [ ] Update CHANGELOG.md

Description Of Changes

Write some things here about the changes and any potential caveats

sanders41 avatar Oct 06 '22 20:10 sanders41

@PSalant726 and @adamsachs I closed the original PR and reopened here to clean up the history

sanders41 avatar Oct 06 '22 20:10 sanders41

I think this is looking good now, going to give it another thorough pass

ThomasLaPiana avatar Oct 09 '22 13:10 ThomasLaPiana

@sanders41 this looks good to me, do you want me to force merge as an admin if you aren't?

ThomasLaPiana avatar Oct 15 '22 14:10 ThomasLaPiana

Yes, that would be good. It won't let me.

sanders41 avatar Oct 15 '22 15:10 sanders41