purs-loader
purs-loader copied to clipboard
ethul
Support ES modules
This PR slightly adjusts the regexps used to rewrite require paths in modules read from the output directory so it supports both CJS and ES modules, in anticipation of https://github.com/purescript/purescript/pull/3791.
PureScript 0.15 has been released and the module system used in the output JavaScript has been changed from CommonJS to ES Modules.
I was wondering if you could this PR could be merged.
I tried this change and it seems to make purs-loader work with PureScript v0.15
@ethul In case you read this: Are you open to merge or add maintainers to this repository or would you rather prefer a fork being published on npm? :)
+1 !
... I came up with exactly the same fix, and was about to submit a PR until I found this one :)
Thanks for the reminder for this. I have fallen a bit behind on PRs, but I will take a look—apologies for the delay!
On Mon, Sep 19, 2022 at 18:45 Olivier Guimbal @.***> wrote:
+1 !
... I came up with exactly the same fix, and was about to submit a PR until I found this one :)
— Reply to this email directly, view it on GitHub https://github.com/ethul/purs-loader/pull/145#issuecomment-1251646395, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACVRS5MYCZFBFP5MHGJYGDV7DUJRANCNFSM4MOP3GFA . You are receiving this because you were mentioned.Message ID: @.***>
This looks great, apologies again for the delay on this. I will endeavor to be more prompt!