splat icon indicating copy to clipboard operation
splat copied to clipboard

Error defining multiple symbols with the same name in different files

Open weirdbeardgame opened this issue 1 year ago • 4 comments

When trying to fill in symbol_addrs.txt I have multiple of the same symbol that exist in different files across my project IE. https://github.com/weirdbeardgame/Fatal-Frame-2/blob/0867e03af6df3f48db396d2826c27eea63c1c1cd/symbol_addrs.txt#L3

Splat will throw an error that symbol already exists Duplicate symbol detected! _fixed_array_verifyrange__H1ZPv_UiUi_PX01 has already been defined at vram 0x0011CF10

Is there some way we can specify what file or scope this exists in?

weirdbeardgame avatar May 12 '24 03:05 weirdbeardgame

Are you referring to files other than the main elf? each file you are disassembling with splat should have its own symbol_addrs file

ethteck avatar May 12 '24 05:05 ethteck

The disassembly generated by splat is always globally visible. There's no concept of file scope, specially because the generated disassembly does not respect the original TUs but instead they disassemble each section of a TU separately.

If you really want to have duplicated symbol names on your symbol_addrs file then you can use the allow_duplicated attribute, but it isn't really recommended because you will get linker errors because of duplicated global symbols. This attribute is only useful for symbols that have been already migrated to C but splat still needs to know about them to reference them properly (like in extracted assets)

AngheloAlf avatar May 12 '24 12:05 AngheloAlf

Are you referring to files other than the main elf? each file you are disassembling with Splat should have its own symbol_addrs file

I mean across the main file. IE, in different header or C, CPP files. It's an effect of them using a generic template or type T and the compiler obviously making multiple implementations for the same thing repeatedly.

weirdbeardgame avatar May 12 '24 15:05 weirdbeardgame

Ah okay, Idk anything about c++ template codegen

ethteck avatar May 12 '24 22:05 ethteck