splat icon indicating copy to clipboard operation
splat copied to clipboard

Doubles not recognized as .rodata

Open blackgamma7 opened this issue 4 years ago • 2 comments

after splitting the .rodata, I found there were errors wherein the double values referred to in the memory region would throw it off, changing the offset and omitting the values. I am uncertain if this is an issue for titles compiled in Mips1, but it seems to be a consistent issue for me, as any .rodata defined that has no doubles recompiles without issue.

blackgamma7 avatar Dec 04 '21 02:12 blackgamma7

Hi, thanks for the report. Can you add which game you're trying to split, as well as your yaml file?

ethteck avatar Dec 04 '21 02:12 ethteck

https://github.com/blackgamma7/mischief-makers/blob/f9bd6f01cb89ff2af5761c9c9383d18a6a1a7f6b/mischiefmakers.yaml#L223

in example, if this line is commented out, it causes the offset for the constant doubles to shift back.

https://github.com/blackgamma7/mischief-makers/blob/f9bd6f01cb89ff2af5761c9c9383d18a6a1a7f6b/mischiefmakers.yaml#L352

un-commenting this line causes the jumptable offset in func_80199CD4_6C49A4 to shift, as well.

blackgamma7 avatar Dec 18 '21 20:12 blackgamma7

gonna close this as it's very obsolete at this point. if it's still an issue with spimdisasm, let us know

ethteck avatar Sep 26 '22 16:09 ethteck