refactor: replace Split in loops with more efficient SplitSeq
strings.SplitSeq (introduced in Go 1.23) returns a lazy sequence (strings.Seq), allowing gopher to iterate over tokens one by one without creating an intermediate slice.
It significantly reduces memory allocations and can improve performance for long strings.
@parithosh @barnabasbusa Hi, Could you please review this PR at your convenience? Thank you very much.
This would be something for @pk910 to review :)
Thanks for the contribution!
We’ve discussed this internally, and while the change is technically reasonable, we’ve decided not to move forward with it. The PR does not introduce new functionality and focuses solely on small code-level optimizations. In general, we avoid accepting changes of this size because they come with some security and maintenance risks - especially in the context of crypto-related projects, where engagement-farming PRs and low-impact drive-by contributions have unfortunately become more common.
To keep the review surface manageable and maintain a clear signal-to-noise ratio, we prefer to reserve contributions for meaningful features, bug fixes, or substantial improvements.
We appreciate the effort, but we’ll close this particular PR.