ethjs-unit icon indicating copy to clipboard operation
ethjs-unit copied to clipboard

Fix toWei(0.1,'wei') from returning 1

Open junderw opened this issue 5 years ago • 4 comments

Fixes #1 and also adds tests for the 2 missing branches (unrelated to this PR) so now coverage is 100% across the board.

junderw avatar Dec 04 '20 01:12 junderw

oof... looks like the dependencies I pulled in are newer than master, so a large diff was created in the pre-commit build...

I'll try to find the version being used here.

junderw avatar Dec 04 '20 01:12 junderw

ok, nvm. all dependencies are specific versions...

Not quite sure how to deal with the built source... Should I maybe just remove them?

This was installed + built using the following node versions btw:

$ node -v
v12.18.3
$ npm -v
6.14.8

junderw avatar Dec 04 '20 01:12 junderw

Coverage Status

Coverage remained the same at 100.0% when pulling fc89e673c03e6dbed4f9d2bb5e80b0b4bc8f75f8 on junderw:fixToWei into 35d870eae1c32c652da88837a71e252a63a83ebb on ethjs:master.

coveralls avatar Dec 04 '20 02:12 coveralls

Reviewing.

SilentCicero avatar Dec 05 '20 17:12 SilentCicero