swarm icon indicating copy to clipboard operation
swarm copied to clipboard

Published 20 hours ago • verified publisher icon ethersphere

Try to recover a consistent state after a crash in swap

Open ralph-pichler opened this issue 5 years ago • 2 comments

A crashing or terminating node issue should be handled IMHO. It is bad design if this leads to problems. There should be some sanity check for example when rebooting the node which recovers the state. I believe this should be analyzed and tackled - even if not with the highest priority. I suggest to create an issue for this.

https://github.com/ethersphere/swarm/issues/1601#issuecomment-559273782

ralph-pichler avatar Dec 03 '19 09:12 ralph-pichler

@ralph-pichler , would this be solved by the batch support PR which was recently merged? Could you please give us some extra insight into this PR? Shall we close it, keep it open, put it back into the backlog? Thanks!

Eknir avatar Feb 06 '20 11:02 Eknir

It should go back to backlog as nobody is working on that.

Batch support helps avoiding this issue in the first place. I would suggest to have a separate issue for refactoring swap to use batches and then afterwards if there are no potential consistency problems left, close this.

ralph-pichler avatar Feb 06 '20 11:02 ralph-pichler