swarm icon indicating copy to clipboard operation
swarm copied to clipboard

Unify variable types between SC and go code

Open vojtechsimetka opened this issue 5 years ago • 4 comments

Problem

Right now there is a mishmatch between the size of numbers (and potentially other types) between the go code and smart contracts. For example the cheque values are 256 bits integers on the SC side but only 64 bits on go code.

Task

Go through the go code and make it compliant with the smart contracts.

vojtechsimetka avatar Jul 17 '19 13:07 vojtechsimetka

This issue was deemed too big to be completed in one go.

As a result, it's going to be implemented through multiple PRs.

The first one, which adds the Uint256 type, is PR #2063.

mortelli avatar Jan 06 '20 00:01 mortelli

This issue was deemed too big to be completed in one go.

As a result, it's going to be implemented through multiple PRs.

The first one, which adds the Uint256 type, is PR #2063.

Part 1 merged.

mortelli avatar Jan 16 '20 13:01 mortelli

Part 2 for implementing this issue has been submitted: PR #2082.

mortelli avatar Jan 27 '20 15:01 mortelli

5-7 working days

Eknir avatar Feb 18 '20 14:02 Eknir