storage-incentives icon indicating copy to clipboard operation
storage-incentives copied to clipboard

Missing StakeUpdated event for changed height

Open ldeffenb opened this issue 1 year ago • 0 comments

According to my observations on the stakeUpdated transactions on the sepolia testnet staking contract (v0.9.2-rc7), it seems that StakeUpdated events are only emitted for invocations that change the stake amount. However, if the height is changed, the effective stake of the node is also affected. The suppression of this event makes actual event-log-based stake tracking impossible.

https://github.com/ethersphere/storage-incentives/blob/9c96668e42a1355f05315b83b222fe689fe22d99/src/Staking.sol#L150-L160

NoLogs: https://sepolia.etherscan.io/tx/0xfbad8fc68e0651191086a9583768472b10b8eba4ee718f02e4099af9e594e435 vs WithLogs: https://sepolia.etherscan.io/tx/0x43be676c04c0fcf18496b3452c1fdff8877c22d797c20d04fc186193fa9e5132

ldeffenb avatar Nov 12 '24 19:11 ldeffenb