bee icon indicating copy to clipboard operation
bee copied to clipboard

Add missing symbol in .golangci.yml

Open damuzhi0810 opened this issue 1 year ago • 1 comments

Checklist

  • [ ] I have read the coding guide.
  • [ ] My change requires a documentation update, and I have done it.
  • [ ] I have added tests to cover my changes.
  • [ ] I have filled out the description and linked the related issues.

Description

Add missing symbol in .golangci.yml

Open API Spec Version Changes (if applicable)

Motivation and Context (Optional)

Related Issue (Optional)

Screenshots (if appropriate):

damuzhi0810 avatar Sep 10 '24 14:09 damuzhi0810

Please use for commits the pattern from here. And you can add back the backticks

martinconic avatar Sep 17 '24 07:09 martinconic

If we use changes made on commit, it will only exclude fmt.Print from specified package path, then linter would report error and will not allow cases like this:

fmt.Printf("starting import process with data-dir at %s\n", dataDir)

or

fmt.Println(beeASCII)

This PR should be rejected and closed. Can you confirm this @istae ?

gacevicljubisa avatar Nov 25 '24 12:11 gacevicljubisa

The current version of golangci-lint being used is v1.61.0. The idea behind the cmd package is to allow the entire family of fmt.Print functions. The linter currently uses an error expression with backticks as specified in the master branch. If we change this to "use of fmt.Print," it will trigger errors for every occurrence of fmt.Print, which may not be the desired behavior.

gacevicljubisa avatar Nov 28 '24 13:11 gacevicljubisa