bee icon indicating copy to clipboard operation
bee copied to clipboard

Published 20 hours ago • verified publisher icon ethersphere

fix: incorrect topup

Open swarmHaseeb opened this issue 2 years ago • 3 comments

Checklist

  • [x] I have read the coding guide
  • [x] My change requires a documentation update and I have done it
  • [x] I have added tests to cover my changes.

Description

Motivation and context (Optional)

Related Issue (Optional)

This PR fixes #3136

Screenshots (if appropriate):

This change is Reviewable

swarmHaseeb avatar Jul 28 '22 11:07 swarmHaseeb

@istae Is there an issue for this?

I dont think this is the right usage of TopUp. TopUp is the topup amount per chunk. This is not the new value of the batch. The normalized balance is not calculated here. The variable name might be misleading.

aloknerurkar avatar Jul 28 '22 12:07 aloknerurkar

@istae Is there an issue for this?

I dont think this is the right usage of TopUp. TopUp is the topup amount per chunk. This is not the new value of the batch. The normalized balance is not calculated here. The variable name might be misleading.

@aloknerurkar so we caught this bug with @swarmHaseeb this morning where when you top up a batch, the amount field is replaced with the value of the batch. There is no issue, maybe we should create one for bookkeeping purposes.

istae avatar Jul 28 '22 13:07 istae

@istae Is there an issue for this? I dont think this is the right usage of TopUp. TopUp is the topup amount per chunk. This is not the new value of the batch. The normalized balance is not calculated here. The variable name might be misleading.

@aloknerurkar so we caught this bug with @swarmHaseeb this morning where when you top up a batch, the amount field is replaced with the value of the batch. There is no issue, maybe we should create one for bookkeeping purposes.

Please find the issue here

ghost avatar Aug 01 '22 09:08 ghost