Do not increment NonceManager delta if transaction send fails

Open wille opened this issue 1 year ago • 2 comments

If the sendTransaction call fails for any reason like your node/provider going down, subsequent calls to sendTransaction will fail until the user manually calls reset in their catch clause wrapping sendTransaction which I would assume not many people do.

Automatically handling this would save people lots of headache and outages.

Aug 21 '24 07:08 wille

Related discussion: https://github.com/ethers-io/ethers.js/issues/972

Aug 21 '24 11:08 kallerosenbaum

I don't agree with this comment. https://github.com/ethers-io/ethers.js/issues/972#issuecomment-663732420

If the documentation of NonceManager.sendTransaction clearly explains that all calls to the function must be in a serial fashion, we should be good.

Aug 21 '24 12:08 kallerosenbaum