ethers.js icon indicating copy to clipboard operation
ethers.js copied to clipboard

[v6] JsonRPCSigner.connectUnchecked is no longer available

Open songkeys opened this issue 2 years ago • 2 comments

In v5, we have a special method connectUnchecked() to "hack" the slow sendTransaction issue (See: https://github.com/ethers-io/ethers.js/issues/340#issuecomment-463802749).

In v6, this method is removed. Is the issue resolved or missed in the migration guide?

songkeys avatar Feb 03 '23 09:02 songkeys

The sendUnchecked is still present, but I didn't port of their connectUncheckedSigner. There were possible issues with it, but let me investigate and try to remember why I made that change. I think it was due to the way the TransactionResponse are returned now. But let me look into it.

It could possibly get rolled into v6.1 too, if the issue wasn't too great.

I'll also research how necessary it is today as well. MetaMask and such are much better at returning local values rather than querying their upstream nodes.

ricmoo avatar Feb 03 '23 09:02 ricmoo

Any update?

nnmax avatar Jul 02 '24 08:07 nnmax