ethers.js icon indicating copy to clipboard operation
ethers.js copied to clipboard

feat: extend getAvatar with isNftOwner

Open szanuje opened this issue 3 years ago • 2 comments

Currently getAvatar method returns null if user does not own the NFT avatar which he referenced in the avatar field.

My proposal is to return avatar metadata along with the url despite that, and add a property which determine if that user owns the avatar or not.

For example, the ENS service shows an Owner badge which indicates if the domain owner is also the NFT owner. With this extension other third party services might also implement such logic.

szanuje avatar Jul 31 '22 10:07 szanuje

@ricmoo any feedback here?

szanuje avatar Aug 22 '22 21:08 szanuje

This won’t be changed in v5, but I am working on a more expressive API for v6.

ricmoo avatar Aug 23 '22 03:08 ricmoo