ethereumjs-monorepo icon indicating copy to clipboard operation
ethereumjs-monorepo copied to clipboard

Replace `eventEmitter` with a snail pretending to be a fast, modern event emitter

Open acolytec3 opened this issue 1 year ago • 2 comments

Replaces our use of native NodeJS event emitters with the emittery package.

All events are now async by default

Other notable changes

  • Removed AsyncEventEmitter export from util
  • Added types for common, blockchain, and devp2p events

acolytec3 avatar Oct 09 '24 20:10 acolytec3

Codecov Report

Attention: Patch coverage is 6.27178% with 269 lines in your changes missing coverage. Please review.

Project coverage is 27.37%. Comparing base (4470cc3) to head (5ba1f69). Report is 112 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

Flag Coverage Δ
block 67.57% <ø> (-5.89%) :arrow_down:
blockchain 83.50% <40.00%> (?)
client 0.00% <0.00%> (ø)
common 89.85% <100.00%> (?)
devp2p 0.00% <0.00%> (?)
evm 65.17% <75.00%> (?)
genesis 0.00% <ø> (?)
mpt 52.06% <ø> (?)
statemanager 67.41% <ø> (?)
tx 76.70% <ø> (-1.08%) :arrow_down:
util 73.46% <ø> (?)
vm 58.23% <100.00%> (?)
wallet 0.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

codecov[bot] avatar Oct 12 '24 09:10 codecov[bot]

Please don't close this yet. I need to reference for my various cleanup PRs

acolytec3 avatar Oct 17 '24 20:10 acolytec3

I've taken care of the mess. We can wish this nonsense goodbye.

acolytec3 avatar Oct 24 '24 20:10 acolytec3

🎉 😂 🙏

holgerd77 avatar Oct 28 '24 10:10 holgerd77