ethereumjs-monorepo icon indicating copy to clipboard operation
ethereumjs-monorepo copied to clipboard

Expand bundle visualizer to monorepo

Open holgerd77 opened this issue 1 year ago • 3 comments

I started this work this morning since I would want to expand the new bundle visualizer from @roninjin10 to all monorepo packages.

However when I add a new vite.config.ts file the tsconfig.json file turns red along and gives out the following error message:

grafik

We should find out what is happening here before we continue here, maybe someone already has some insight.

Maybe this vite config additions directly to the build command have side effects (eventually already for EVM), and we would want to make sure that this does not affect other processes.

holgerd77 avatar Jun 19 '24 07:06 holgerd77

Line 6-7 already shows up in VScode for me (has been for a while). Not sure about the node types issue but the one about module resolution can be fixed by changing our dev build environment from CJS to ESM.

acolytec3 avatar Jun 19 '24 10:06 acolytec3

For the second error that looks like an actual misconfiguration of tsconfig. I think for a library like Ethjs module and moduleResolution being set to NodeNext is the ideal configuration.

The first error message maybe it just wants you to npm install @types/node?

roninjin10 avatar Jun 19 '24 11:06 roninjin10

This might be solved with our recent of config changes. Will take another look

acolytec3 avatar Jul 14 '24 12:07 acolytec3