ethereumjs-monorepo icon indicating copy to clipboard operation
ethereumjs-monorepo copied to clipboard

Point hardhat tests to the upgrade branch

Open acolytec3 opened this issue 2 years ago • 5 comments

WIP

acolytec3 avatar Jul 26 '22 02:07 acolytec3

Codecov Report

Merging #2076 (e16b893) into master (e16b893) will not change coverage. The diff coverage is n/a.

:exclamation: Current head e16b893 differs from pull request most recent head 826bd8e. Consider uploading reports for the commit 826bd8e to get more accurate results

Impacted file tree graph

Flag Coverage Δ
block 93.07% <0.00%> (ø)
blockchain 88.82% <0.00%> (ø)
client 86.70% <0.00%> (ø)
common 98.09% <0.00%> (ø)
devp2p 92.33% <0.00%> (ø)
ethash ∅ <0.00%> (∅)
evm 79.07% <0.00%> (ø)
rlp ∅ <0.00%> (∅)
statemanager 88.71% <0.00%> (ø)
trie 89.26% <0.00%> (ø)
tx 97.98% <0.00%> (ø)
util 93.14% <0.00%> (ø)
vm 85.27% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

codecov[bot] avatar Jul 26 '22 02:07 codecov[bot]

Ah, interesting. Cool! 🙂

holgerd77 avatar Aug 01 '22 11:08 holgerd77

It's only cool if I get it to work :grimacing: I'm stumped at the moment though I suspect it's currently related to our beta releases somehow messing up the versioning in verdaccio.

acolytec3 avatar Aug 01 '22 12:08 acolytec3

Is this more about "helping HH to update" (and so even eventually leading to PRs on the HH side)? Or rather for finding inconsistencies in our own implementation?

(also asking because first possibility is likely also the job for the HH people to some greater extend?)

holgerd77 avatar Aug 02 '22 09:08 holgerd77

The main goals were to see if the job even worked, which it wasn't and then to give me a tracking sense of where their work was in terms of integrating (and maybe reveal any bugs in our code if it surfaces)

acolytec3 avatar Aug 02 '22 12:08 acolytec3

Outdated, will close.

holgerd77 avatar Feb 14 '24 12:02 holgerd77