ECIPs icon indicating copy to clipboard operation
ECIPs copied to clipboard

Update ecip-1066.md

Open chris-mercer opened this issue 1 year ago • 6 comments
trafficstars

Add Spiral

chris-mercer avatar Feb 16 '24 00:02 chris-mercer

I would like more descriptive commits and branch name (@chris-mercer especially since you're pushing directly to the ethereumclassic remote). Without viewing the patch itself I have no idea what's going on here.

meowsbits avatar Feb 21 '24 14:02 meowsbits

I would like more descriptive commits and branch name (@chris-mercer especially since you're pushing directly to the ethereumclassic remote). Without viewing the patch itself I have no idea what's going on here.

Done! 7c210cf6e166e30992f8a6f77ec5f36289784e47

gitr0n1n avatar Feb 25 '24 19:02 gitr0n1n

Cool thanks :+1:

meowsbits avatar Feb 28 '24 13:02 meowsbits

How was eip-6049 implemented? It is not included in the 'expected action' portion and the spec is dubious + poorly defined. My understanding is this is a warning in documentation(?) to not use selfdestruct. As written, 6049 opens the door to reuse the opcode for something that a contract may not have intended when deployed. In the comments in geth it looks like we will eventually treat it as a noop after the activation block. I would recommend having it as a permanent 'noop' and not be allowed to be repurposed. ack this flag allows compatibility with eth. Its implementation or lack there of is included in this ecip update

realcodywburns avatar Mar 05 '24 12:03 realcodywburns

In core-geth IsEIP6049 is inoperative; it's just a paper placeholder, and afaiu that's the spec. Duly noted on the suggestion to permanent noop it.

meowsbits avatar Mar 06 '24 14:03 meowsbits

Sounds good to me. can we squash merge this now?

realcodywburns avatar Mar 09 '24 21:03 realcodywburns