staking-launchpad
staking-launchpad copied to clipboard
ethereum
Goerli / Prater: silently fails on big amount of validators
I've been testing this with Goerli / Prater testnets, so not sure if this applies to mainnet.
During the last step, on the page with "send all deposits", a GET request is made (containing all the beacon chain public keys?).
It would fail silently on a big amount of deposits because of GET-request URL length limit. Which is terrible.
As far as I'm aware, if you do make more than 100 requests the 1st 100 deposits will still be checked it is just that the remainder will not. I don't think this is a terrible failure mode as the main reason for checking this is to protect against the user uploading the same deposit_data.json twice.
That said, I agree that it should warn the user that onle the 1st 100 deposits have been checked.
@CarlBeek Oh I think it'll fail on much less than 100 deposits. HTTP GET URL length limit is 2,048 characters. A public key is 48 bytes, or 96 characters. Which limits the request to ~22 validators.