staking-launchpad icon indicating copy to clipboard operation
staking-launchpad copied to clipboard

Feature request: Check for already sent deposits on deposit page.

Open Belkaar opened this issue 4 years ago • 3 comments

Problem: If the deposit process for multiple validators is aborted and then started again by uploading the json file again the launchpad will send the eht again.

Maybe it could check which deposits are already made and not offer those transactions.

Belkaar avatar Aug 16 '20 17:08 Belkaar

I would almost call this a bug and not a feature request. There are plenty of very good reasons a user might have to stop and restart the deposit process: not enough ETH in wallet, browser/computer/internet/etc issues, and so on. The expected behaviour should be that the page shows the same deposit indications even if the user has been forced to close it and re-upload the json in order to resume depositing. See https://github.com/ethereum/ethereum-org-website/issues/1581

emansipater avatar Oct 05 '20 18:10 emansipater

See #166 for an example of a user reporting exactly the issue that results. There is no warning and significant consequences. In my mind that makes it a bug.

emansipater avatar Oct 05 '20 18:10 emansipater

This has been a major issue for me when joining Medalla, causing multiple deposits (96 ETH) in the contract for one validator and two other validators never being able to use.

pk27734 avatar Nov 02 '20 07:11 pk27734