solidity icon indicating copy to clipboard operation
solidity copied to clipboard

Added glossary to resources

Open PatrickAlphaC opened this issue 7 months ago • 1 comments

We have a glossary with many of the terms taught in Cyfrin Updraft.

https://www.cyfrin.io/glossary

Figured it would be a good resource to add!

(Note: It's different from what's in https://github.com/ethereum/solidity/pull/15339)

PatrickAlphaC avatar Jun 09 '25 13:06 PatrickAlphaC

Thank you for your contribution to the Solidity compiler! A team member will follow up shortly.

If you haven't read our contributing guidelines and our review checklist before, please do it now, this makes the reviewing process and accepting your contribution smoother.

If you have any questions or need our help, feel free to post them in the PR or talk to us directly on the #solidity-dev channel on Matrix.

github-actions[bot] avatar Jun 09 '25 13:06 github-actions[bot]

Ping @mehtavishwa30.

cameel avatar Aug 05 '25 09:08 cameel

@mehtavishwa30 This needs a rebase and squashing. I think you used the "Update branch" feature to do it, but without switching it to "rebase". If you do that, it creates a merge commit (which we do not want).

cameel avatar Aug 12 '25 11:08 cameel

@cameel got it. it also has some failing checks. What are those about?

mehtavishwa30 avatar Aug 12 '25 12:08 mehtavishwa30

There seems to be some new rate-limiting going on with our Foundry version check and that makes a lot of external test jobs fail.

They're unrelated to the PR and they're not required checks so you can ignore them.

cameel avatar Aug 12 '25 12:08 cameel

Well, seems like a few required tests are failing now. @cameel will wait for you to check those before rebasing and merging.

mehtavishwa30 avatar Aug 13 '25 13:08 mehtavishwa30

It's already reabased and fine to merge, but there seems to be something weird happening on CircleCI side. All of these jobs should not be failing.

cameel avatar Aug 13 '25 14:08 cameel

I can make a new PR if that's easier

PatrickAlphaC avatar Aug 14 '25 01:08 PatrickAlphaC

Maybe it would have been easier after all, it seems like the commit was borked somehow or at least the circleci cache for it was borked. :D Anyways, I've performed some git surgery

git reset --soft HEAD~1
git commit --author="Patrick Collins <[email protected]>" -m "feat: added updraft glossary for solidity and smart contract terms" --date="Mon Jun 9 09:50:22 2025 -0400"
git push --force-with-lease tmp feat/updraft-addition

where tmp is your remote. This creates a new commit with the exact same author info and contents (but with me as the committer, that's why it's showing both our avatars next to the commit). That causes circle ci to start fresh cache-wise. No need for a new PR.

clonker avatar Aug 14 '25 08:08 clonker

Well, when pushing the squashed commit I first accidentally pushed it as a branch named PatrickAlphaC/feat/updraft-addition instead of pushing feat/updraft-addition to PatrickAlphaC and quickly deleted it. This probably started CI on that branch and immediately killed it, failing all jobs. I did not connect this to the CI failure here, because it's a completely new branch, but now that you mentioned it, it could have confused CircleCI. I remember that weird things used to happen with CircleCI if you renamed a branch just before opening a PR, by renaming it locally, pushing it and deleting the branch with the old name. The CI would be all red from the start in such a PR.

It's just very unintuitive that CircleCI gets confused by something like this. The way I understand it, the checks are supposed to be connected with a branch, not with a commit. But I guess they must be doing some caching to avoid rerunning multiple times on the same commit and that breaks this mental model in unexpected ways.

cameel avatar Aug 14 '25 12:08 cameel