solidity icon indicating copy to clipboard operation
solidity copied to clipboard

[easy] fix minor issues

Open sky-coderay opened this issue 9 months ago • 2 comments

libyul/optimiser/CommonSubexpressionEliminator.cpp libyul/optimiser/DataFlowAnalyzer.cpp

/*( -deleted (

sky-coderay avatar Mar 14 '25 08:03 sky-coderay

Thank you for your contribution to the Solidity compiler! A team member will follow up shortly.

If you haven't read our contributing guidelines and our review checklist before, please do it now, this makes the reviewing process and accepting your contribution smoother.

If you have any questions or need our help, feel free to post them in the PR or talk to us directly on the #solidity-dev channel on Matrix.

github-actions[bot] avatar Mar 14 '25 08:03 github-actions[bot]

Thank you for your contribution :) there are a couple more of these hiding throughout the codebase. Could you fix them all and bundle it all up in one single commit?

clonker avatar Mar 14 '25 08:03 clonker

Hey @sky-coderay , I found these other places where we could also fix and bundle everything together. Are you up for finishing that?

libyul/CompilabilityChecker.cpp:/*(
libyul/optimiser/SyntacticalEquality.cpp:/*(
libyul/optimiser/StackCompressor.cpp:/*(
libyul/optimiser/UnusedPruner.cpp:/*(
libyul/optimiser/Rematerialiser.cpp:/*(
libyul/optimiser/Metrics.cpp:/*(
libyul/optimiser/DataFlowAnalyzer.cpp:/*(
libyul/optimiser/CommonSubexpressionEliminator.cpp:/*(

matheusaaguiar avatar Apr 16 '25 19:04 matheusaaguiar

Yes , sure

sky-coderay avatar Apr 16 '25 20:04 sky-coderay

@matheusaaguiar ready , thanks

sky-coderay avatar Apr 16 '25 21:04 sky-coderay