solidity icon indicating copy to clipboard operation
solidity copied to clipboard

eof: new contract creation

Open rodiazet opened this issue 1 year ago • 2 comments

~Depends on #15456.~ Merged Depends on https://github.com/ethereum/solidity/pull/15521

rodiazet avatar Oct 14 '24 10:10 rodiazet

Thank you for your contribution to the Solidity compiler! A team member will follow up shortly.

If you haven't read our contributing guidelines and our review checklist before, please do it now, this makes the reviewing process and accepting your contribution smoother.

If you have any questions or need our help, feel free to post them in the PR or talk to us directly on the #solidity-dev channel on Matrix.

github-actions[bot] avatar Oct 14 '24 10:10 github-actions[bot]

Please add has dependencies label.

rodiazet avatar Oct 18 '24 13:10 rodiazet

If you want, some of the things mentioned above ther could potentially be put in a separate PR(s) to make this one smaller:

  • Disabling datasize(), dataoffset(), datacopy(), setimmutable(), loadimmutable() on EOF (https://github.com/ethereum/solidity/pull/15512#discussion_r1809294208).
  • Adding ControlFlowSideEffects to createFunction() (https://github.com/ethereum/solidity/pull/15512#discussion_r1809364632)
  • Making the name of the current object available in AsmAnalyzer (https://github.com/ethereum/solidity/pull/15512#discussion_r1809315347).

cameel avatar Oct 21 '24 19:10 cameel

It doesn't build now because we have to merge two dependencies first.

rodiazet avatar Oct 22 '24 21:10 rodiazet

#15536 has been merged. Please rebase.

cameel avatar Oct 30 '24 11:10 cameel