solidity icon indicating copy to clipboard operation
solidity copied to clipboard

Move tests from test/libsolidity/ViewPureChecker.cpp to syntaxTests/viewPureChecker

Open AbhinavMir opened this issue 1 year ago • 3 comments

Potential fix for https://github.com/ethereum/solidity/issues/14796

AbhinavMir avatar Jan 25 '24 05:01 AbhinavMir

Thank you for your contribution to the Solidity compiler! A team member will follow up shortly.

If you haven't read our contributing guidelines and our review checklist before, please do it now, this makes the reviewing process and accepting your contribution smoother.

If you have any questions or need our help, feel free to post them in the PR or talk to us directly on the #solidity-dev channel on Matrix.

github-actions[bot] avatar Jan 25 '24 05:01 github-actions[bot]

Sorry, but this change does not address the issue at all.

The idea is to take all tests from test/libsolidity/ViewPureChecker.cpp, create equivalent syntax tests and remove the .cpp file.

cameel avatar Jan 26 '24 15:01 cameel

Hi @cameel , this is still in the works. I've posted a question on the original issue, posting it here for convenience: Would the test runner pick up these tests automatically or do I need to index the new tests somewhere?

Thanks!

AbhinavMir avatar Jan 26 '24 21:01 AbhinavMir

Thanks for the attempt, but currently it doesn't look like there is progress here, so I'm closing the PR.

ekpyron avatar Aug 15 '24 12:08 ekpyron