solidity icon indicating copy to clipboard operation
solidity copied to clipboard

Update documentation about `codehash` behaviour according to EIP-1052 and EIP-161

Open ustas-eth opened this issue 1 year ago • 5 comments

Fixes https://github.com/ethereum/solidity/issues/14794 by adding a warning for the codehash usage.

ustas-eth avatar Jan 21 '24 13:01 ustas-eth

Thank you for your contribution to the Solidity compiler! A team member will follow up shortly.

If you haven't read our contributing guidelines and our review checklist before, please do it now, this makes the reviewing process and accepting your contribution smoother.

If you have any questions or need our help, feel free to post them in the PR or talk to us directly on the #solidity-dev channel on Matrix.

github-actions[bot] avatar Jan 21 '24 13:01 github-actions[bot]

Please, see the following issue: https://github.com/ethereum/solidity/issues/14794

ustas-eth avatar Jan 21 '24 13:01 ustas-eth

Thanks @ustas-eth. Could you please just squash the commits and rebase with the develop branch? :)

r0qs avatar Apr 26 '24 10:04 r0qs

@r0qs I did, but I'm not sure if the result is what you expected. I'm not very proficient with git :')

ustas-eth avatar Apr 26 '24 16:04 ustas-eth

@r0qs I did, but I'm not sure if the result is what you expected. I'm not very proficient with git :')

haha no problem, I fixed it for you ;)

Thanks a lot for your contribution!

r0qs avatar Apr 26 '24 16:04 r0qs