solidity icon indicating copy to clipboard operation
solidity copied to clipboard

Clean up documentation with regards to deprecated `selfdestruct`

Open nikola-matic opened this issue 3 years ago • 6 comments

As selfdestruct is to be deprecated, and now even triggers a deprecation warning (see https://github.com/ethereum/solidity/issues/13844, https://github.com/ethereum/solidity/pull/13884), the docs should be fully updated to reflect this, whether by adding additional deprecation warnings, or by altering any existing examples so as not to suggest the usage of selfdestruct.

Changes should be made in the following files:

docs/cheatsheet.rst
docs/contracts/function-modifiers.rst
docs/contracts/functions.rst
docs/contracts/inheritance.rst
docs/examples/micropayment.rst
docs/internals/optimizer.rst
docs/metadata.rst
docs/security-considerations.rst
docs/smtchecker.rst
docs/style-guide.rst
docs/using-the-compiler.rst

nikola-matic avatar Jan 26 '23 08:01 nikola-matic

Hey i want to try this

Coderayush13 avatar Jan 30 '23 13:01 Coderayush13

Solving this issue!

Coollaitar avatar Mar 11 '23 14:03 Coollaitar

Just a note for future (and current) contributors: if this is the first issue you've tackled in this project, consider finding another one, since this one is more complicated than it might seem - in some cases it would require re-writing existing code samples to not use selfdestruct, which in certain cases may even mean writing completely new ones. In addition, before you open a PR for this issue (and for most of them really), please ask first if the issue is appropriate for a first time contributor, because otherwise we have to be the bad guys and close your PR, or invest our time into fixing something that was not of high priority (or is at least a much lower priority than what we currently have going on). By all means feel free to contribute (we would really appreciate it), just make sure to ask first if the issue you've got your eyes on is a good fit. Cheers.

nikola-matic avatar Mar 14 '23 19:03 nikola-matic

Just a note for future (and current) contributors: if this is the first issue you've tackled in this project, consider finding another one, since this one is more complicated than it might seem - in some cases it would require re-writing existing code samples to not use selfdestruct, which in certain cases may even mean writing completely new ones. In addition, before you open a PR for this issue (and for most of them really), please ask first if the issue is appropriate for a first time contributor, because otherwise we have to be the bad guys and close your PR, or invest our time into fixing something that was not of high priority (or is at least a much lower priority than what we currently have going on). By all means feel free to contribute (we would really appreciate it), just make sure to ask first if the issue you've got your eyes on is a good fit. Cheers.

Okay ser!

Coollaitar avatar Mar 15 '23 02:03 Coollaitar

This should now also account for https://eips.ethereum.org/EIPS/eip-6780

ekpyron avatar Dec 20 '23 11:12 ekpyron

https://github.com/ethereum/go-ethereum/tree/f1794ba2788baf34489847bfa9ca00e067507db0

Rashann2471 avatar Dec 23 '23 06:12 Rashann2471