solidity
solidity copied to clipboard
ethereum
Fix misspelling in bug name in `bugs.json` (`NestedCallataArrayAbiReencodingSizeValidation`)
Thanks for the fix but I'm not really sure if we want to change that at this point. It's been there for a long time (~3 years) and I think some tools may not be prepared for changes like that. For example I know that Etherscan displays these identifiers and I'm not sure how it would actually behave.
Personally I'd be for leaving it as is, but we should get more opinions. @chriseth, @axic?
Thanks for the fix but I'm not really sure if we want to change that at this point. It's been there for a long time (~3 years) and I think some tools may not be prepared for changes like that. For example I know that Etherscan displays these identifiers and I'm not sure how it would actually behave.
Personally I'd be for leaving it as is, but we should get more opinions. @chriseth, @axic?
3 years? Hasn't this just been there since April this year?
Ah, you're right :) I looked at when first affected version was released rather than when we fixed it. It's actually the reencode bug we fixed not so long ago.
Well, in that case maybe it makes sense to fix it, though I still wonder if some tools might be caching these IDs?
Ah, you're right :) I looked at when first affected version was released rather than when we fixed it. It's actually the reencode bug we fixed not so long ago.
Well, in that case maybe it makes sense to fix it, though I still wonder if some tools might be caching these IDs?
I'm not sure, maybe we should try to reach out - but generally, I'd tend towards fixing it.
Yeah, if it's so fresh, I'm for fixing it too. I'll ask on the tooling channel just in case.
@cameel @ekpyron wait, I thought it was decided this wasn't going to be changed?
@cameel @ekpyron wait, I thought it was decided this wasn't going to be changed?
We actually decided that we want to change this, we just wanted to ping Etherscan to see if this may cause issues for them.
The problem is how to reach them. I don't think their support form is the best way to do that for something like this.
I got a response from Etherscan guys that fixing this is fine as far as they're concerned. They don't have this hard-coded anywhere.
On the other hand - apparently that's not the only typo we have :) There's a much older one that one's better left as is.