solidity icon indicating copy to clipboard operation
solidity copied to clipboard

Disallow comparison operators on contracts

Open Marenz opened this issue 2 years ago • 5 comments

fixes #11700 depends on #12566

Marenz avatar Jan 20 '22 16:01 Marenz

[rebased this using github's rebase button]

ekpyron avatar Feb 14 '22 19:02 ekpyron

This will need forking of the external test repos.

ekpyron avatar Feb 14 '22 19:02 ekpyron

This will need forking of the external test repos.

Bump this

leonardoalt avatar Apr 04 '22 09:04 leonardoalt

Since this is a bit stale anyway, maybe it would be a good idea to first submit some upstream PRs changing those comparisons? With a bit of luck, we'll be able to merge it without having to switch to forks. Or we'll at least reduce their number.

cameel avatar Apr 04 '22 12:04 cameel

I changed it to a draft until our external tests are ready for this. Updated the issue accordingly as well.

Marenz avatar Jun 21 '22 12:06 Marenz

any updates?

leonardoalt avatar Aug 11 '22 21:08 leonardoalt

The current state here is that the external tests need to be updated; This is open for take over at the moment.

Marenz avatar Aug 18 '22 15:08 Marenz

Looks like we don't have resources to pursue this now and the PR itself is not that complicated so I'd vote for closing this now and getting back to this later, when we can actually spend some time on getting upstream projects to adopt the change.

cameel avatar Oct 28 '22 11:10 cameel

Given the amount of external test failures, i.e. the extent of the real-world usage of these comparisons, I'm closing the PR. Actually, I'm even considering closing the issue, but I'll leave it open for the time being.

ekpyron avatar Nov 01 '22 11:11 ekpyron