remix-project icon indicating copy to clipboard operation
remix-project copied to clipboard

Integrate solidity scan in udapp

Open Aniket-Engg opened this issue 10 months ago • 1 comments

Aniket-Engg avatar Apr 17 '24 13:04 Aniket-Engg

Deploy Preview for remixproject ready!

Name Link
Latest commit 0bf6ee73c78cec794236757fd4ebd8ba06edcb9c
Latest deploy log https://app.netlify.com/sites/remixproject/deploys/6666e7f158325300095c9785
Deploy Preview https://deploy-preview-4735--remixproject.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Apr 17 '24 13:04 netlify[bot]

Modal UX isn't really working ok, I don't want to interfer with any UX decision, but it seems to me that logging the result to the terminal is just fine. Also you won't have the issue of having to design a modal..

yann300 avatar Jun 03 '24 16:06 yann300

Modal UX isn't really working ok, I don't want to interfer with any UX decision, but it seems to me that logging the result to the terminal is just fine. Also you won't have the issue of having to design a modal..

Terminal will also not be better to show this data IMO. May be we can adjust the modal size.

Aniket-Engg avatar Jun 04 '24 06:06 Aniket-Engg

  • For the user who doesn't know what solidity scan is, the tooltip says nothing. Can you expand there?
  • The modal for permission makes me anxious because I still don't know what solidity scan is, and I should share my code now. I would 99% not do it with this data. To improve this we can add more info in the modal and include the link to the project.
  • columns are too narrow. I assume this is because you are using our default modal and it has some restrictions. you can either create a custom one or alter the existing one to have 2-3 more views
  • there are some

    tags in your rightmost column

  • close is not closing the modal for me

Screenshot from 2024-06-04 08-24-41

LianaHus avatar Jun 04 '24 06:06 LianaHus

  • For the user who doesn't know what solidity scan is, the tooltip says nothing. Can you expand there?

Updated! Please check

  • The modal for permission makes me anxious because I still don't know what solidity scan is, and I should share my code now. I would 99% not do it with this data. To improve this we can add more info in the modal and include the link to the project.

Updated! Please check

  • there are some tags in your rightmost column

This has been handled. Tags should not be there

  • close is not closing the modal for me

It is working fine for me

Aniket-Engg avatar Jun 04 '24 08:06 Aniket-Engg

@yann300 @LianaHus I have increased modal size and handled your comment.

Aniket-Engg avatar Jun 05 '24 14:06 Aniket-Engg