remix-project icon indicating copy to clipboard operation
remix-project copied to clipboard

Published 20 hours ago • verified publisher icon ethereum

Save deployed contracts

Open Aniket-Engg opened this issue 1 year ago • 1 comments

This allow saving a contract for injected web3 provider

Aniket-Engg avatar Feb 09 '24 13:02 Aniket-Engg

Deploy Preview for remixproject ready!

Name Link
Latest commit 2835f6f0f00bec360ad8686b545739d36f979cbf
Latest deploy log https://app.netlify.com/sites/remixproject/deploys/65dc89bd0ec50800081eb807
Deploy Preview https://deploy-preview-4524--remixproject.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Feb 09 '24 13:02 netlify[bot]

Saved contracts don't work while using the AtAddress feature

yann300 avatar Feb 26 '24 08:02 yann300

when switching networks, only the saved contracts from the current network should be displayed.

yann300 avatar Feb 26 '24 09:02 yann300

  1. As we discussed previously in the initial call, "Currently, you have no saved contracts to interact with." It takes too much space. the one for deployed contracts was fine as long as there was nothing shown after that. now we have 2 huge fields there that attract too much unnecessary attention. Maybe try to remove the alert and leave a text warning or info at least saved once.

  2. There are issues in the flow.

  • First of all, once the user saves, we remove the TX from the second list. it is confusing and we destroy the order.
  • Second - once we remove it from the "saved" list, it doesn't come back to the "Deployed.." list but disappears.

LianaHus avatar Feb 26 '24 09:02 LianaHus

when switching networks, only the saved contracts from the current network should be displayed.

this is done

Aniket-Engg avatar Feb 26 '24 12:02 Aniket-Engg

  1. As we discussed previously in the initial call, "Currently, you have no saved contracts to interact with." It takes too much space. the one for deployed contracts was fine as long as there was nothing shown after that. now we have 2 huge fields there that attract too much unnecessary attention. Maybe try to remove the alert and leave a text warning or info at least saved once.
  2. There are issues in the flow.
  • First of all, once the user saves, we remove the TX from the second list. it is confusing and we destroy the order.
  • Second - once we remove it from the "saved" list, it doesn't come back to the "Deployed.." list but disappears.

point 2 is done

Aniket-Engg avatar Feb 26 '24 12:02 Aniket-Engg

the time displayed for the saved on property shows GMT timezone, it would be better to show the current timezone. (probably not for this PR though)

yann300 avatar Feb 26 '24 12:02 yann300

Saved contracts don't work while using the AtAddress feature

I think this feature is also working

Aniket-Engg avatar Feb 26 '24 12:02 Aniket-Engg