remix-project icon indicating copy to clipboard operation
remix-project copied to clipboard

Published 20 hours ago • verified publisher icon ethereum

Undo file actions

Open iamsethsamuel opened this issue 2 years ago • 9 comments

Last actions on files such as moving, rename, creating and deleting a file can now be undone with Ctrl+Z

iamsethsamuel avatar Sep 08 '22 22:09 iamsethsamuel

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
remix-project ✅ Ready (Inspect) Visit Preview Oct 12, 2022 at 9:15AM (UTC)

vercel[bot] avatar Sep 08 '22 22:09 vercel[bot]

I have fixed the merge conflict

iamsethsamuel avatar Sep 13 '22 13:09 iamsethsamuel

Please can someone merge this so that I can send the next PR?

iamsethsamuel avatar Sep 17 '22 04:09 iamsethsamuel

Please can someone merge this so that I can send the next PR?

Yes, but we need to discuss some things about it.

bunsenstraat avatar Sep 21 '22 16:09 bunsenstraat

3 things

  • when I switch workspace it should remove the recorded actions otherwise you'd be undoing it in another workspace
  • the undo action should be available globally: so ie you are doing a file rename, and then click somewhere else it should still undo, even when the cursor is in the editor. so these things should be linked if we can do that... might be hard. or we have another way except ctrl-z. Macs btw don't use CTRL.
  • the undo actions should have a modal ( I think ) telling you you're undoing something.

bunsenstraat avatar Sep 21 '22 17:09 bunsenstraat

Okay, I modelled it after VSCode's implementation. Which I think most people are used to so if the behaviour is different here I guess it will create a confusion. I think the file explorer in windows and Linux also require focus to work. So imagine I working on the editor and want to undo my code and I undo a rename. That will be weird.

As for the dialog, you can always redo so I don't see the need for it.

The workspace is very important, let me see if I can implement it.

And I don't have a Mac so I don't know how things work there. If someone can help implement it that will be awesome.

Just my thoughts, but we can do it your way

iamsethsamuel avatar Sep 21 '22 18:09 iamsethsamuel

I think it would be good to have a call with the team and discuss how we could do it. Would that fit for you?

bunsenstraat avatar Sep 21 '22 19:09 bunsenstraat

Thank you for making this effort btw!! It's a great idea.

bunsenstraat avatar Sep 21 '22 20:09 bunsenstraat

I think it would be good to have a call with the team and discuss how we could do it. Would that fit for you?

Yes, when will you be free for the call

iamsethsamuel avatar Sep 21 '22 22:09 iamsethsamuel

Please can someone review this?

iamsethsamuel avatar Oct 12 '22 09:10 iamsethsamuel

Deploy Preview for remixproject ready!

Name Link
Latest commit 1356a319b7aae4bc02ef040c2953944ab1a0bd22
Latest deploy log https://app.netlify.com/sites/remixproject/deploys/63ea2ae64422010008553afd
Deploy Preview https://deploy-preview-2897--remixproject.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Nov 22 '22 11:11 netlify[bot]