remix-project icon indicating copy to clipboard operation
remix-project copied to clipboard

feat: Theme Hacker Owl

Open koolamusic opened this issue 3 years ago • 16 comments

Hi Guys, created something here out of a little burning need, I'd be using remix a lot and thus wanted an IDE with a bit of a modern look and feel.

I consider this continuous WIP, and would take responsibility for this theme even as I continue to use it for my work. Adds a monospace font and sans-serif and also, I'd find a way to map more ace-identifier keywords to the syntax highlight config.

Also I create theme color variables using CSS Variables, so that the theme can easily be adapted. Feedback is welcome, like I said, this will be a continuous effort.

Thanks

https://user-images.githubusercontent.com/8960757/131011195-957e65ba-0b99-46a3-b28d-fc6da2cc7afc.mov

koolamusic avatar Aug 26 '21 17:08 koolamusic

@LianaHus had time to review?

koolamusic avatar Sep 01 '21 16:09 koolamusic

@LianaHus had time to review?

looks good to me. thanks for your contribution! :)

LianaHus avatar Sep 06 '21 08:09 LianaHus

Screenshot 2021-09-06 at 11-21-12 Remix - Ethereum IDE

@LianaHus added the patches.

koolamusic avatar Sep 06 '21 11:09 koolamusic

Screenshot 2021-09-06 at 11-21-12 Remix - Ethereum IDE

@LianaHus added the patches.

i still don't see the 'border' between switch tab and terminal

LianaHus avatar Sep 13 '21 10:09 LianaHus

Screenshot 2021-09-06 at 11-21-12 Remix - Ethereum IDE @LianaHus added the patches.

i still don't see the 'border' between switch tab and terminal

I feel like I am missing something. is there a way you could annotate the section.

koolamusic avatar Sep 13 '21 10:09 koolamusic

image

@LianaHus see this

koolamusic avatar Sep 13 '21 11:09 koolamusic

the contrast between right border of panel and bg is not enough to see it but it is visible anyway, so if you like it like that I don't mind

LianaHus avatar Oct 05 '21 08:10 LianaHus

ok, let me take a look at it

koolamusic avatar Oct 05 '21 09:10 koolamusic

image

Added the fixes and changed the sidebar panel color to fix concerns with the contrast between the left and right panel.

koolamusic avatar Oct 05 '21 11:10 koolamusic

@LianaHus can we please go over this again, what do I need to move this PR ?

koolamusic avatar Nov 13 '21 10:11 koolamusic

Our back and forth has taken pretty long time. We'd like to either merge this or close your pr soon. If you can make these updates, we can get this in a release very soon). The next release is in 2 weeks.

  • [ ] In the settings Hacker Owl should go after Candy. ( we do this)

  • [ ] the background of the input fields is too light causing the place holder text need a bit more contrast to make it more legible.

  • [ ] new variables in the editor are not defined in your theme: image here there slightly visible: image

  • [ ] remove contextView.js (right click in editor). Please rebase. You probably had put this in place before we switched to Monaco API.

ryestew avatar Jul 05 '22 16:07 ryestew

I'll merge all tonight I apoligize I had to move into a new home

Get Outlook for Androidhttps://aka.ms/AAb9ysg


From: Rob @.> Sent: Tuesday, July 5, 2022 12:42:54 PM To: ethereum/remix-project @.> Cc: Heather @.>; Comment @.> Subject: Re: [ethereum/remix-project] feat: Theme Hacker Owl (#1527)

Our back and forth has taken pretty long time. We'd like to either merge this or close your pr soon. If you can make these updates, we can get this in a release very soon). The next release is in 2 weeks.

  • In the settings Hacker Owl should go after Candy. ( we do this)
  • the background of the input fields is too light causing the place holder text need a bit more contrast to make it more legible.
  • new variables in the editor are not defined in your theme:

[image]https://user-images.githubusercontent.com/6050001/177374805-13c5f6ec-c4ec-4168-907f-ba44e4bec2ea.png

here there slightly visible:

[image]https://user-images.githubusercontent.com/6050001/177374870-4214602e-c6f9-4468-aae4-43524083b725.png

  • remove contextView.js (right click in editor). Please rebase. You probably had put this in place before we switched to Monaco API.

— Reply to this email directly, view it on GitHubhttps://github.com/ethereum/remix-project/pull/1527#issuecomment-1175267015, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AT5C7EDTBYPSY3IEDRRK2B3VSRQY5ANCNFSM5C33XS7A. You are receiving this because you commented.Message ID: @.***>

Hbutlercapone avatar Jul 05 '22 18:07 Hbutlercapone

@Hbutlercapone do you need any assistance with this?

koolamusic avatar Jul 07 '22 01:07 koolamusic

Our back and forth has taken pretty long time. We'd like to either merge this or close your pr soon. If you can make these updates, we can get this in a release very soon). The next release is in 2 weeks.

* [ ]  In the settings Hacker Owl should go after Candy.  ( we do this)

* [ ]  the background of the input fields is too light causing the place holder text need a bit more contrast to make it more legible.

* [ ]  new variables in the editor are not defined in your theme:
image here there slightly visible: image
* [ ]  remove contextView.js  (right click in editor).  Please rebase. You probably had put this in place before we switched to Monaco API.
image image

These issues have been resolved

koolamusic avatar Jul 29 '22 12:07 koolamusic

Its saying its pending two other reviewers reviews

Get Outlook for Androidhttps://aka.ms/AAb9ysg


From: U.M Andrew @.> Sent: Friday, July 29, 2022 8:13:22 AM To: ethereum/remix-project @.> Cc: Heather @.>; Mention @.> Subject: Re: [ethereum/remix-project] feat: Theme Hacker Owl (#1527)

Our back and forth has taken pretty long time. We'd like to either merge this or close your pr soon. If you can make these updates, we can get this in a release very soon). The next release is in 2 weeks.

  • [ ] In the settings Hacker Owl should go after Candy. ( we do this)

  • [ ] the background of the input fields is too light causing the place holder text need a bit more contrast to make it more legible.

  • [ ] new variables in the editor are not defined in your theme:

[image]https://user-images.githubusercontent.com/6050001/177374805-13c5f6ec-c4ec-4168-907f-ba44e4bec2ea.png here there slightly visible: [image] https://user-images.githubusercontent.com/6050001/177374870-4214602e-c6f9-4468-aae4-43524083b725.png

  • [ ] remove contextView.js (right click in editor). Please rebase. You probably had put this in place before we switched to Monaco API.

[image]https://user-images.githubusercontent.com/8960757/181755792-83570653-c08c-46a4-b8d4-902a29f33c0b.png

[image]https://user-images.githubusercontent.com/8960757/181755931-955e2e78-9bd4-460f-8dcd-6760f98f8356.png

These issues have been resolved

— Reply to this email directly, view it on GitHubhttps://github.com/ethereum/remix-project/pull/1527#issuecomment-1199206042, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AT5C7EFTL5W3SKXGJLTRGQLVWPDGFANCNFSM5C33XS7A. You are receiving this because you were mentioned.Message ID: @.***>

Hbutlercapone avatar Jul 29 '22 19:07 Hbutlercapone

@ryestew <> @LianaHus ^^

koolamusic avatar Aug 08 '22 18:08 koolamusic

Please remove all changes to contextView.js and we will take care of that part. So the only files that should be in your pr are remix-hacker_owl.css and theme-module.js. Then we can merge it! Thanks

@koolamusic Can you consider this?

Aniket-Engg avatar Aug 18 '22 06:08 Aniket-Engg

Please remove all changes to contextView.js and we will take care of that part. So the only files that should be in your pr are remix-hacker_owl.css and theme-module.js. Then we can merge it! Thanks

@koolamusic Can you consider this?

Yes. on it

koolamusic avatar Aug 19 '22 09:08 koolamusic

Thanks for your continuous co-operation and this great contribution @koolamusic !!!

Aniket-Engg avatar Aug 19 '22 17:08 Aniket-Engg

My pleasure ❤️

koolamusic avatar Aug 22 '22 20:08 koolamusic