remix-project icon indicating copy to clipboard operation
remix-project copied to clipboard

Highlight input field in UDapp when missing param (encoding error)

Open ninabreznik opened this issue 6 years ago • 10 comments

ninabreznik avatar May 22 '18 14:05 ninabreznik

in the multiparam component (https://github.com/ethereum/remix-ide/blob/master/src/multiParamManager.js) When the control is expanded:

  • should listen on focus out
  • if the encoding failed, input border should become red

@ryestew please could you double check that this correspond to what we planned

yann300 avatar Jun 13 '18 15:06 yann300

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


This issue now has a funding of 0.4 ETH (217.38 USD @ $543.46/ETH) attached to it.

gitcoinbot avatar Jun 21 '18 03:06 gitcoinbot

@yann300 can you add images where I can reproduce this error?

iamonuwa avatar Jun 21 '18 16:06 iamonuwa

@iamonuwa that's not a bug. The idea here is to properly warn the user when data can't be encoded:

screenshot from 2018-06-24 10 47 52

screenshot from 2018-06-24 10 47 23

in this example, the function take one parameter (address) - in both case, when the focus is out and if encoding failed , the input border should become red.

yann300 avatar Jun 24 '18 08:06 yann300

Thank you @yann300

iamonuwa avatar Jun 24 '18 12:06 iamonuwa

@iamonuwa Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • [x] warning (3 days)
  • [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot avatar Jun 27 '18 16:06 gitcoinbot

Issue Status: 1. Open 2. Cancelled


Work has been started.

These users each claimed they can complete the work by 10 months ago. Please review their action plans below:

1) willdeuschle has started work.

I'm going to alter the display presented on the page based on whether or not the address provided is valid.

Learn more on the Gitcoin Issue Details page.

gitcoinbot avatar Jun 30 '18 00:06 gitcoinbot

Here is the functionality provided now. If you click into the box when it's expanded, edit the address, and then leave the box, it will turn red if the address is invalid and remain gray otherwise:

screen shot 2018-06-30 at 8 40 23 pm

willdeuschle avatar Jul 01 '18 00:07 willdeuschle

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work for 0.4 ETH (181.83 USD @ $454.57/ETH) has been submitted by:

  1. @willdeuschle

@vs77bb please take a look at the submitted work:

  • PR by @willdeuschle

gitcoinbot avatar Jul 01 '18 01:07 gitcoinbot

Issue Status: 1. Open 2. Cancelled


The funding of 0.4 ETH (97.57 USD @ $243.93/ETH) attached to this issue has been cancelled by the bounty submitter

gitcoinbot avatar May 20 '19 21:05 gitcoinbot