py_ecc icon indicating copy to clipboard operation
py_ecc copied to clipboard

Published 20 hours ago • verified publisher icon ethereum

[WIP] Added type hinting

Open 6ug opened this issue 6 years ago • 7 comments

Fixes https://github.com/ethereum/py_ecc/issues/11 Totally fine tuned manually! automated tools not handling dynamic execution.

6ug avatar Oct 18 '18 16:10 6ug

PR https://github.com/ethereum/py_ecc/pull/19 should fix ^^ above CI failures.

6ug avatar Oct 18 '18 22:10 6ug

Looks like ci failures are some small linting errors, and failing due to python 2.7 not supporting type hints.

@carver I'm inclined to drop python 2 support. Can you confirm?

pipermerriam avatar Oct 19 '18 17:10 pipermerriam

I'm inclined to drop python 2 support. Can you confirm?

Yeah, the next release can be v2 :+1:

carver avatar Oct 19 '18 18:10 carver

@6ug looks like this needs to be rebased against master

pipermerriam avatar Oct 23 '18 15:10 pipermerriam

@pipermerriam our last typing: Module not found issue was due to - python3.4 does not have inbuilt support for PEP-484 type hinting, we need to externally add typing in this case, https://github.com/ethereum/py_ecc/pull/18/commits/d86ca0e2afe7a69cc4b6b967bc81ba0b03a2db90 will fix that.

6ug avatar Oct 27 '18 22:10 6ug

We should drop py3.4 as well, while we're dropping old python versions. Maybe even py3.5 too.

carver avatar Oct 28 '18 05:10 carver

ping @6ug are you still working on this?

pipermerriam avatar Nov 15 '18 17:11 pipermerriam