py-wasm icon indicating copy to clipboard operation
py-wasm copied to clipboard

Published 20 hours ago • verified publisher icon ethereum

[WIP] S-expression parsing of text modules

Open pipermerriam opened this issue 6 years ago • 3 comments

What was wrong?

Issue #

How was it fixed?

Summary of approach.

Cute Animal Picture

put a cute animal picture link inside the parentheses

pipermerriam avatar Feb 15 '19 19:02 pipermerriam

Was just taking a look at this. It looks like you've written a grammar which is pretty explicit. Is there a reason you didn't go with a more generic s-expression grammar and then verify s-expression content as a kind of post-processing step? I'm wondering if that wouldn't be simpler and allow you to forgo any possible headaches relating to writing a lengthy grammar.

davesque avatar Mar 08 '19 06:03 davesque

Actually, reviewing the WASM spec now, it looks like the text grammar is pretty well-defined. So I guess that's probably one reason you did it that way.

davesque avatar Mar 08 '19 07:03 davesque

Actually, reviewing the WASM spec now, it looks like the text grammar is pretty well-defined. So I guess that's probably one reason you did it that way.

Yeah, I took their provided grammar and am converting it bit-by-bit to parsimonious.

I had that thought yesterday (use a generic s-expression grammar), but I think I like the up-front validation that this explicit grammar provides.

pipermerriam avatar Mar 08 '19 14:03 pipermerriam