py-evm icon indicating copy to clipboard operation
py-evm copied to clipboard

Incrementally building clique blocks doesn't work

Open gsalgado opened this issue 5 years ago • 1 comments

Trying to incrementally build clique blocks fails (the state root will be wrong on the final block) because the initial header is not signed so all tx fees are incorrectly assigned to the coinbase address.

gsalgado avatar Nov 06 '20 10:11 gsalgado

We should also probably get rid of https://github.com/ethereum/py-evm/blob/3b79b353311924273f44a5458904302b341f5816/eth/consensus/clique/clique.py#L102 as it lets one incrementally build a block that in the end won't be valid

gsalgado avatar Nov 06 '20 11:11 gsalgado