populus icon indicating copy to clipboard operation
populus copied to clipboard

Package using deprecated eth-util methods.

Open mbeacom opened this issue 6 years ago • 2 comments

  • Populus Version: 2.2.0
  • OS: linux

What was wrong?

Populus attempts to import deprecated methods from eth-utils:

File "/usr/local/lib/python3.6/site-packages/populus/utils/mappings.py", line 8, in <module>
    from eth_utils import (
ImportError: cannot import name 'force_text'

This error is encountered when attempting to run pytest from the https://github.com/gitcoinco/web/ codebase with eth-utils==1.0.1

Relates to: https://github.com/ethereum/eth-utils/pull/69/

I'm uncertain whether or not you'd prefer a compat module to handle ImportError exceptions for backwards compatibility or outright changes to the existing imports.

Cute Animal Picture

squirrel

mbeacom avatar Mar 01 '18 14:03 mbeacom

I think upgrading to the newest version would be best, but that's likely going to be a decently broad set of changes.

pipermerriam avatar Mar 01 '18 17:03 pipermerriam

@mbeacom any chance of submitting a PR with your fixes?

petri avatar May 28 '18 17:05 petri