populus icon indicating copy to clipboard operation
populus copied to clipboard

Update json schema to accept "fallback" type functions

Open pipermerriam opened this issue 7 years ago • 5 comments

  • Populus Version: 1.8.0
  • OS: osx/linux/win

What was wrong?

Solidity now includes an ABI entry for the fallback function which is not valid under the current json-schema used to validate contract data.

How can it be fixed?

Update the json-schema here: https://github.com/pipermerriam/populus/blob/3a0445e550baa344a0931a2b94f3c779c98505fe/populus/assets/contract-data.v1.schema.json#L48-L50

A new option should be added for a FallbackFunctionABI which allows for {"type": "fallback"}.

Cute Animal Picture

put a cute animal picture here.

baby-honey-badger

pipermerriam avatar Aug 04 '17 19:08 pipermerriam

I think this has been implemented by @miohtama in https://github.com/ethereum/populus/pull/331/commits/7db1bc4c7f86273c135a026ae62c305d0c79d6d0, as part of PR #331.

(Actually .transact()ing to the fallback seems impossible ATM, which is properly mentioned in the last note in this section of the docs.)

IMO OK to close.

veox avatar Jan 04 '18 14:01 veox

hey @pipermerriam can I start working on this issue?

Rupeshiya avatar Jun 23 '18 22:06 Rupeshiya

@Rupeshiya as mentioned above this has already been implemented in https://github.com/ethereum/populus/pull/331/

palash25 avatar Jun 24 '18 06:06 palash25

oh...I see..

Rupeshiya avatar Jun 24 '18 07:06 Rupeshiya

Can this be closed? I got here via https://gitcoin.co/issue/gitcoinco/web/1471/636 and this appears to be stale.

jaymcgrath avatar Nov 24 '18 19:11 jaymcgrath