hive
hive copied to clipboard
graphql: fix tests according to spec
I'm making a reference issue here to follow up on a couple of inconsistencies between the graphql tests and the graphql spec.
I opened an issue on Besu to discuss differences between geth and besu graphql implementations. In some areas, geth is not compliant with the spec (which will be fixed shortly), but Besu also implemented queries on Account
which was discussed here, but never formally included in the spec. Also Besu returns numbers for Status
whereas the spec asks for Long
(geth returns hex strings for Status
).
So far, here are the inconsistencies / issues:
-
Status
-- spec asks forLong
. Geth returns hex string (which is presumably correct) and Besu returns number. Graphql tests currently expect a number which is incorrect. - Gas-related queries (
estimateGas
,cumulativeGas
,gasLimit
,gasUsed
) should return number instead of hex string -- geth is working on fixing this. Besu has it correctly implemented. - Block number queries should return number instead of hex string -- geth is working on fixing this. Besu has it correctly implemented.
- Queries on
Account
should either be formally included in the spec (in which case, should also be implemented in geth) or removed from the graphql test suite.