go-ethereum icon indicating copy to clipboard operation
go-ethereum copied to clipboard

cmd/evm: benchmarking via `statetest` command + filter by name, index and fork

Open jwasinger opened this issue 1 year ago • 2 comments

When evm statetest --bench is specified, benchmark the execution similarly to evm run. It will explicitly error if there is more than one matched subtest to be executed (new statetest flags are added to filter which tests are ran).

Breaks the state test runner API. But I figure that we are the only consumers of this API, so it's not a big problem?

jwasinger avatar Sep 16 '24 11:09 jwasinger

Sorry -- I know I approved it earlier, and I came around to merge it now, but then I found some more things that could be improved :)

holiman avatar Sep 30 '24 14:09 holiman

Tried to re-run the exact test you posted from goevmlab: ~/go/src/github.com/holiman/goevmlab/examples/sstore_static/sstore_test.json but it appears that it isn't in the repo.

Running a separate test shows no measurable performance difference between the latest changes and master branch.

jwasinger avatar Oct 01 '24 08:10 jwasinger