go-ethereum icon indicating copy to clipboard operation
go-ethereum copied to clipboard
verified publisher icon ethereum

all: remove loopvar workarounds in tests and linter

Open estensen opened this issue 1 year ago • 2 comments

Loop gotcha was fixed in 1.22 and is currently set as the min version:

https://github.com/ethereum/go-ethereum/blob/922eb033d3553d97907506d08fdb1e0ccdc5bead/go.mod#L3

estensen avatar Sep 02 '24 15:09 estensen

I think we should not remove the workaround just yet.

fjl avatar Sep 02 '24 21:09 fjl

I think we should not remove the workaround just yet.

@fjl Why?

holiman avatar Sep 13 '24 13:09 holiman

Thanks, but this was instead taken care of when we upgraded the linter, as part of https://github.com/ethereum/go-ethereum/pull/30587. I missed including this PR, sorry

holiman avatar Nov 08 '24 07:11 holiman