go-ethereum icon indicating copy to clipboard operation
go-ethereum copied to clipboard

all: implement EIP-6110, execution layer triggered deposits

Open lightclient opened this issue 10 months ago • 3 comments

This PR implements EIP-6110: Supply validator deposits on chain. It also sketches out the base for Prague in the engine API types. I plan to base future Prague EIP work against this PR.

lightclient avatar Apr 01 '24 21:04 lightclient

We added some logics in downloader when we introduce withdrawal, i guess it's same for deposit?

rjl493456442 avatar Apr 15 '24 07:04 rjl493456442

We need to allow prague in fcuV3 as well

MariusVanDerWijden avatar May 08 '24 09:05 MariusVanDerWijden

I like the handwritten decoder much better, I did a bunch of fuzzing of the types and nothing came up, but I haven't verified that the decoding is_actually_ correct

MariusVanDerWijden avatar Jul 22 '24 12:07 MariusVanDerWijden

I think there's a missing validation in consensus.verifyHeader

fyi

	prague := chain.Config().IsPrague(header.Number, header.Time)
	if !prague {
		if header.RequestsHash != nil {
			return fmt.Errorf("invalid requestsRoot: have %d, expected nil", header.RequestsHash)
		}
	} else {
		if header.RequestsHash == nil {
			return errors.New("header is missing requestsRoot")
		}
	}

islishude avatar Sep 03 '24 11:09 islishude

@islishude that occurs in state_validator.go.

lightclient avatar Sep 04 '24 07:09 lightclient

that occurs in state_validator.go.

it doesn't have a validation for the chain fork rule

islishude avatar Sep 04 '24 08:09 islishude

Hi, there.

I found 2 bugs, please help review the pr #30422 and #30423

islishude avatar Sep 12 '24 09:09 islishude